On Thursday 13 August 2009 03:35:32 am Hans de Goede wrote:
> Hi,
>
> The whole set looks good. I've got one small suggested change for patch
> 10 though, can you please put () around the
> defined(__sparc__) && defined(__arch64__)
> to make it clear the && takes precedence over the ||'s. I know this will
> work without the () too, this is just for clarity.
>
> If you resend the last patch with this small change, then I'll commit the
> set *once the alpha is out of the door*, not that I expect this to cause
> any issues, but better safe then sorry.
>
> Regards,
>
> Hans
Hi Hans
Thanks for the quick review.
I just sent a new patch with your recommendations.
Dennis
> On 08/12/2009 09:22 PM, Dennis Gilmore wrote:
> > ---
> > loader/init.c | 10 +++++++++-
> > 1 files changed, 9 insertions(+), 1 deletions(-)
> >
> > diff --git a/loader/init.c b/loader/init.c
> > index 8037de0..627428e 100644
> > --- a/loader/init.c
> > +++ b/loader/init.c
> > @@ -333,8 +333,16 @@ static int setupTerminal(int fd) {
> >
> > return 0;
> > }
> > +#if defined(__sparc__)
> > +static int termcmp(struct termios *a, struct termios *b) {
> > + if (a->c_iflag != b->c_iflag || a->c_oflag != b->c_oflag ||
> > + a->c_cflag != b->c_cflag || a->c_lflag != b->c_lflag)
> > + return 1;
> > + return memcmp(a->c_cc, b->c_cc, sizeof(a->c_cc));
> > +}
> > +#endif
> >
> > -#if !defined(__s390__)&& !defined(__s390x__)
> > +#if !defined(__s390__)&& !defined(__s390x__)&& !defined(__sparc__)
> > static int termcmp(struct termios *a, struct termios *b) {
> > if (a->c_iflag != b->c_iflag || a->c_oflag != b->c_oflag ||
> > a->c_cflag != b->c_cflag || a->c_lflag != b->c_lflag ||
>
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
