Re: [PATCH] Don't try to get dso deps of statically linked files.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thu, 6 Aug 2009, Jesse Keating wrote:

This was causing get_dso_deps to go haywire when encountering
statically linked things like /sbin/grub.  Particularly bad
on x86_64 when it would try to use the 64bit LDSO to run the
32bit executable.  The output would be bad enough that it would
short circuit our loop to install all the things in KEEPFILES.  We
noticed this because on x86_64 the gtk2 theme is what is listed after
/sbin/grub in keepfiles, and we weren't getting our theme on x86_64.
---
scripts/buildinstall.functions |    3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/scripts/buildinstall.functions b/scripts/buildinstall.functions
index 2afb652..af90070 100755
--- a/scripts/buildinstall.functions
+++ b/scripts/buildinstall.functions
@@ -110,7 +110,8 @@ instFile() {
    fi

    f=$(file $FILE)
-    echo $f | egrep -q ": (setuid )?ELF" &&  {
+    echo $f | egrep -q ": (setuid )?ELF" &&
+    echo $f | egrep -qv "statically linked" &&  {
        if echo $f | grep -q " 64-bit " ; then
            get_dso_deps $(pwd) "$FILE" lib64
        else


Applied.

- -- David Cantrell <dcantrell@xxxxxxxxxx>
Red Hat / Honolulu, HI

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkp7iNsACgkQ5hsjjIy1VkkxXQCfV9QMrKnuJcHGKOeWJE3pFpCN
ZJwAn3OAQX+Cw+IHiGWA1WfpSDJympkP
=barT
-----END PGP SIGNATURE-----

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux