-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Fri, 3 Jul 2009, Steffen Maier wrote:
On 07/03/2009 08:39 AM, David Cantrell wrote:
When a partition table is unreadable, anaconda displays a
window explaining the situation and asks you if you would
like to format the disk for use. The existing message would
only give the device node name (e.g., /dev/sda47). This
patch adds the drive model name and capacity to the message
so confused users might know which disk anaconda is talking
about.
diff --git a/storage/devicetree.py b/storage/devicetree.py
index 08846f3..c199212 100644
--- a/storage/devicetree.py
+++ b/storage/devicetree.py
@@ -126,10 +126,18 @@ def questionInitializeDisk(intf=None, name=None):
+ _("Error processing drive %s (%s %-0.fMB).\n\n"
"Maybe it needs to be reinitialized. "
+ "YOU WILL LOSE ALL DATA ON THIS DRIVE!")
+ % (name, dev.model, dev.getSize(),),
Just one little comment regarding disks on s390. With DASDs the model
and hence the size are unfortunately often the same for disks in the
system. Thus they would still not be distinguishable. What do you think
about adding the symlink name of /dev/disk/by-path as well? This would
unambiguously identify all kinds of disk (DASD and zFCP on s390).
The 'name' value should already contain that information, unless I'm mistaken.
For example, on my system, I might see:
Error processing drive sda (ATA SAMSUNG MMCRE64G 61052MB).
So you would still see dasda and so on for s390.
- --
David Cantrell <dcantrell@xxxxxxxxxx>
Red Hat / Honolulu, HI
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkpSrycACgkQ5hsjjIy1Vkk42wCfXNF8De/T7n9G8Qp9RO9EULTt
OBMAn1V1hy26LxBQWCScEYc3Ll4pNPio
=2hw8
-----END PGP SIGNATURE-----
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
