[PATCH] Fix traceback in second editing of existing raid dev (#497234).

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This only fixes the traceback, and suppresses "Original filesystem
type" label if it is lying (2nd edit). The problem is we are not
editing original format request, but the last one requested.
---
 iw/raid_dialog_gui.py |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/iw/raid_dialog_gui.py b/iw/raid_dialog_gui.py
index 652a050..26ecd8f 100644
--- a/iw/raid_dialog_gui.py
+++ b/iw/raid_dialog_gui.py
@@ -384,7 +384,7 @@ class RaidEditor:
 	    lbl.set_mnemonic_widget(self.fstypeCombo)
             maintable.attach(self.fstypeCombo, 1, 2, row, row + 1)
             row += 1
-        else:
+        elif origrequest.format.exists:
             maintable.attach(createAlignedLabel(_("Original File System Type:")),
                              0, 1, row, row + 1)
             if format.type:
@@ -490,7 +490,10 @@ class RaidEditor:
 	# format or not?
 	self.formatButton = None
 	self.fsoptionsDict = {}
-	if not format.exists:
+        # XXX multiple editing of request is broken - it doesn't edit the
+        # original format but the last one requested which makes e.g. Migrate
+        # option broken
+	if False and not format.exists:
 	    self.formatButton = gtk.CheckButton(_("_Format partition?"))
 	    if not format.type:
 		self.formatButton.set_active(1)
-- 
1.5.4.3

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux