On Wed, 2009-04-22 at 13:51 +0200, Radek Vykydal wrote:
> Behaves like in F10, tested.
> Note that the patch dosn't fix the case when VGs are regrown
> (shrinked) upon editing of existing request, but that is more
> general bug - traceback on failure of size checks after editing
> of partition size. I think I'll look at it too.
I think the correct behavior is to not change the size of a partition
once it is part of a VG or an MD array. I have a patch here that filters
immutable partitions before calling allocatePartitions and
growPartitions. It might be a slight departure from F10, but it makes
the most sense IMO. I was going to post the patch today, but you
reassigned the bug to yourself and posted this one while I slept. Very
sneaky ;-)
>
> ---
> iw/partition_gui.py | 7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/iw/partition_gui.py b/iw/partition_gui.py
> index 8a283cf..4375178 100644
> --- a/iw/partition_gui.py
> +++ b/iw/partition_gui.py
> @@ -1004,6 +1004,13 @@ class PartitionWindow(InstallWindow):
> try:
> doPartitioning(self.storage)
> rc = 0
> + # check that regrown VGs can hold preallocated LVs
> + for vg in self.storage.vgs:
> + if vg.freeSpace < 0:
> + raise PartitioningError, _("Adding this partition would not "
> + "leave enough disk space for already "
> + "allocated logical volumes in "
> + "%s." % (vg.name))
> except PartitioningError, msg:
> self.intf.messageWindow(_("Error Partitioning"),
> _("Could not allocate requested partitions: %s.") % (msg),
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
