Re: [PATCH] Prevent segfault when network install method fails in loader.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/17/2009 07:52 AM, Chris Lumens wrote:
diff --git a/loader/loader.c b/loader/loader.c
index 7b3eb0c..f960c28 100644
--- a/loader/loader.c
+++ b/loader/loader.c
@@ -1378,7 +1378,7 @@ static char *doLoaderMain(struct loaderData_s *loaderData,
                                        _("OK"), _("Back"), NULL);
                   }

-                if (rc&&   rc != 1) {
+                if (rc&&   (rc != 1)&&   (loaderData->method == -1)) {
                       loaderData->method = -1;
                       step = STEP_KBD;
                       dir = -1;
Ugh, ok just having a bad day.  That if statement should read:

if ((rc&&  rc != 1) || (loaderData->method == -1)) {

Looks okay, I suppose.  This kind of stuff is notoriously hard to get
right, so I hope you gave it a good bit of testing.

Yeah, I haven't merged it yet because I've found another install case where it breaks. Working on an improvement.

--
David Cantrell <dcantrell@xxxxxxxxxx>
Red Hat / Honolulu, HI

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux