On Tue, 2009-04-14 at 21:53 -0400, Jeremy Katz wrote:
> It's not really a libata limitation -- it's the scsi layer. And we
> should probably handle the limitations which are present for other disk
> types too (partedUtils.py had a list of most of them)
>
> ... that said
>
> On Tuesday, April 14 2009, David Lehman said:
> > diff --git a/storage/devices.py b/storage/devices.py
> > index 080cd7f..d01fcc7 100644
> > --- a/storage/devices.py
> > +++ b/storage/devices.py
> > @@ -798,6 +798,10 @@ class DiskDevice(StorageDevice):
> > if not self.mediaPresent:
> > raise DeviceError("cannot commit to disk %s which has no media" % self.name)
> >
> > + if self.name.startswith("sd") and \
> > + self.partedDisk.lastPartitionNumber > 15:
> > + raise DeviceError("disk %s has too many partitions" % self.name)
> > +
>
> Traceback'ing here is probably not ideal. People certainly have setups
> with more partitions than we support. We just have to ignore the later
> ones
Ok, I was really just shooting for parity with the old code, which
silently refused to do any commits on disks with more than 15
partitions. If we're going to actually think about it, the thing to do
is catch the preexisting setups in devicetree.py, and also add a
check/dialog to the partitioning ui to prevent users from creating such
setups. This will have to wait until tomorrow. I'll post a new patch
soon.
Dave
>
> Jeremy
>
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
