On Tue, 2009-04-14 at 11:04 -0400, Jeremy Katz wrote:
> On Tuesday, April 14 2009, Chris Lumens said:
> > > > storage/__init__.py | 6 +++---
> > > > 1 files changed, 3 insertions(+), 3 deletions(-)
> > > >
> > > > diff --git a/storage/__init__.py b/storage/__init__.py
> > > > index 4c365f7..8678b6e 100644
> > > > --- a/storage/__init__.py
> > > > +++ b/storage/__init__.py
> > > > @@ -470,11 +470,11 @@ class Storage(object):
> > > > if part.active and \
> > > > not part.getFlag(parted.PARTITION_RAID) and \
> > > > not part.getFlag(parted.PARTITION_LVM) and \
> > > > - part.fileSystemType in ("ext3", "ext2", "fat16", "fat32"):
> > > > - dests.append(part.path, device.name)
> > > > + part.fileSystem.type in ("ext3", "ext2", "fat16", "fat32"):
> > > > + dests.append([part.path, device.name])
> > >
> > > Perhaps a dumb question, but do we care about ext4 here too?
> >
> > Yes, yes we do.
> >
> > We really need a better test here than keeping a static list. Perhaps
> > we should make this the sum of linux filesystems and msdos filesystems?
>
> Maybe we should just go for a blacklist of things which aren't mountable
> rather than having a list of things which are? ntfs and swap would be
> the two I'd then add to the not allowed list
If this code used the devicetree instead of iterating over the
parted.Disk's partitions we could use the same code we use everywhere
else: device.format.mountable. Done and done. That's what it's there
for.
>
> Jeremy
>
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
