Re: [PATCH] Prevent segfault when network install method fails in loader.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/13/2009 05:41 PM, David Cantrell wrote:
Happens at least for NFS installs, but if we fail to mount and present
the failure newt window and the user chooses Retry, loader segfaults.
If loaderData->method is -1, we need to force them back through the
network configuration stages (which is part of a fix for an older bug
that would prevent users from changing the network settings if the
network install method failed).
---
  loader/loader.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/loader/loader.c b/loader/loader.c
index 7b3eb0c..f960c28 100644
--- a/loader/loader.c
+++ b/loader/loader.c
@@ -1378,7 +1378,7 @@ static char *doLoaderMain(struct loaderData_s *loaderData,
                                       _("OK"), _("Back"), NULL);
                  }

-                if (rc&&  rc != 1) {
+                if (rc&&  (rc != 1)&&  (loaderData->method == -1)) {
                      loaderData->method = -1;
                      step = STEP_KBD;
                      dir = -1;

Ugh, ok just having a bad day.  That if statement should read:

if ((rc && rc != 1) || (loaderData->method == -1)) {

Calling it a day here.

--
David Cantrell <dcantrell@xxxxxxxxxx>
Red Hat / Honolulu, HI

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux