Hi,
Erm, the same typo from my last review is still in there
(you changed it but its still wrong)
-ENEEDMORECAFEINE ?
On 04/10/2009 07:22 PM, Joel Granados Moreno wrote:
---
iw/lvm_dialog_gui.py | 166 ++++++++++++++++++++++++++++++++------------------
1 files changed, 107 insertions(+), 59 deletions(-)
<snip>
+ failed = False
+ for func in lv_checks:
+ if not func(*[], **kwargs):
+ falied = True
falied should be failed
+ break
+ if failed:
continue
+ # FIXME: handle the globals better.
+ size = long(size)
+
# Ok -- now we've done all the checks to validate the
# user-specified parameters. Time to set up the device...
origname = templv.lvname
Other then that its ok, so if you fix that feel free to commit. Also maybe
some testing like trying to enter an lv_name which is already in use, that
would have caught this one.
Regards,
Hans
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
