Hans de Goede wrote:
On 04/10/2009 03:33 PM, Jacek Danecki wrote:
If array was created before this patch disallow to create new
MDRaidArrayDevice object.
It make an assumption that array for md member is created by function
handleUdevMDMeberFormat.
Maybe we can drop function addUdevMDDevice?
Attached patch:
-- a/storage/devicetree.py
+++ b/storage/devicetree.py
@@ -998,6 +998,15 @@ class DeviceTree(object):
except (KeyError, IndexError, ValueError) as e:
log.warning("invalid data for %s: %s" % (name, e))
return
+
+ if md_uuid:
+ md_array = self.getDeviceByUuid(md_uuid)
+ if md_array:
+ log.debug("MD array md_uuid=%s already created" % (md_uuid))
+ return md_array
In my tests this function ended always in the same way with return md_array.
So next is not run anymore.
If I make an good assumption we can drop code below.
+
+ if self.md_is_container(md_level):
+ return device
device = MDRaidArrayDevice(name,
level=md_level,
Erm, shouldn't that last return be "return None" or just "return" ?
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
