On 04/09/2009 11:41 AM, Jacek Danecki wrote:
Hans de Goede wrote:
This still does not look right, this will cause partitions
which are part of an mdraid (normal mdraid use) to
be added to the tree as storage devices, instead of partitions
which is wrong, and we do not need this, we only need
to add fakeraid member disks to the tree as StorageDevice instead
of DiskDevice, and we alrady do that with the
udev_device_is_dmraid set. Please drop this function
and the special case calling it, it is not needed.
I've renamed udev_device_is_dmraid to udev_device_is_fakeraidset_member
and removed udev_device_is_mdraid. This works correctly with partition
used for native md format.
What do you think about this patch below.
I'm not completely happy with it, but I understand why it needs to be
done this way when using Dave's approach to the cmdline option handling,
so its ok.
Regards,
Hans
-def udev_device_is_dmraid(info):
+def udev_device_is_fakeraidset_member(info):
# Note that this function does *not* identify raid sets.
# Tests to see if device is parto of a dmraid set.
# dmraid and mdriad have the same ID_FS_USAGE string, ID_FS_TYPE has a
@@ -303,7 +303,8 @@ def udev_device_is_dmraid(info):
# dmraid will be everything that is raid and not linux_raid_member
from formats.dmraid import DMRaidMember
if info.has_key("ID_FS_TYPE") and \
- info["ID_FS_TYPE"] in DMRaidMember._udevTypes:
+ ((info["ID_FS_TYPE"] in DMRaidMember._udevTypes ) or \
+ (info["ID_FS_TYPE"] == "isw_raid_member" )):
return True
return False
Also can you please next time attach patches instead of sending
them inline, your mail client is mangling them.
Can you correctly see patch included above? I've checked my emails I'd
sent to the list, using 2 mail clients, and didn't see any problem with
mangling.
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
