Re: [PATCH] Put the lv checks in inner functions.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

See comments below.

<snip>

+ # Here start the lv_check_functions
+ # Before we dare to create an lv device we check for stuff. Gather all
+ # the checkfunctions in inner functions and put them in a list. This
+ # decouples the check functions from the creating device stuff. For
+ # all the checks True means pass and False means Fail.
+ def lv_check_validadte_name(*args, **kwargs):

Spelling: "lv_check_validadte_name" ? (You have been consistent
in this, so its not a syntax problem).

<snip>

+ for func in lv_checks:
+ if not func(*[], **kwargs):
+ Falied = True

spelling, real error this time Falied -> failed.

+ if failed:
continue


Other then that it looks good,

Regards,

Hans

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux