Re: [PATCH 5/8] Changes for using mdadm for isw_raid_member

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Why the check for md_uuid after calling getDeviceByUuid() ?

You should check that you have a md_uuid before calling
getDeviceByUuid(), otherwise it will return the first device
without an uuid!

Regards,

Hans


On 04/08/2009 03:15 PM, Jacek Danecki wrote:
  create container for isw

diff --git a/storage/devicetree.py b/storage/devicetree.py
index e4cab60..36e8610 100644
--- a/storage/devicetree.py
+++ b/storage/devicetree.py
@@ -994,14 +994,23 @@ class DeviceTree(object):
except (KeyError, IndexError, ValueError) as e:
log.warning("invalid data for %s: %s" % (name, e))
return
-
- device = MDRaidArrayDevice(name,
- level=md_level,
- memberDevices=md_devices,
- uuid=md_uuid,
- exists=True,
- parents=slaves)
- self._addDevice(device)
+ + md_array = self.getDeviceByUuid(md_uuid)
+ if md_uuid and md_array:
+ log.debug("--md_uuid=%s already created" % (md_uuid))
+ device = md_array
+ else:
+ if md_level == "container":
+ # FIXME: it is hardcoded name of container
+ name = "imsm"
+
+ device = MDRaidArrayDevice(name,
+ level=md_level,
+ memberDevices=md_devices,
+ uuid=md_uuid,
+ exists=True,
+ parents=slaves)
+ self._addDevice(device)

return device


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux