On 04/08/2009 03:07 PM, Jacek Danecki wrote:
New iswmd parameter for kernel cmdline
diff --git a/storage/formats/__init__.py b/storage/formats/__init__.py
index 784bb1c..1bdc7c5 100644
--- a/storage/formats/__init__.py
+++ b/storage/formats/__init__.py
@@ -3,6 +3,9 @@
#
# Copyright (C) 2009 Red Hat, Inc.
#
+# Copyright (C) 2009 Intel Corporation
+# April 2009 - Changes for MD support for isw format
+#
# This copyrighted material is made available to anyone wishing to use,
# modify, copy, or redistribute it subject to the terms and conditions of
# the GNU General Public License v.2, or (at your option) any later
version.
@@ -112,6 +115,9 @@ def collect_device_format_classes():
log.debug("import of device format module '%s' failed" % mod_name)
def get_device_format_class(fmt_type):
+ from mdraid import MDRaidMember
+ from dmraid import DMRaidMember
The dmraid import is not needed.
+ from flags import flags
""" Return an appropriate format class based on fmt_type. """
if not device_formats:
collect_device_format_classes()
@@ -122,6 +128,10 @@ def get_device_format_class(fmt_type):
if fmt_type and fmt_type == fmt_class._name:
fmt = fmt_class
break
+ elif fmt_type == "isw_raid_member" and flags.cmdline.has_key("iswmd"):
+ log.debug("found MD cmdline parameter")
+ fmt = MDRaidMember
+ break
elif fmt_type in fmt_class._udevTypes:
fmt = fmt_class
break
diff --git a/storage/udev.py b/storage/udev.py
index 63cc3fd..b56599f 100644
--- a/storage/udev.py
+++ b/storage/udev.py
@@ -3,6 +3,9 @@
#
# Copyright (C) 2009 Red Hat, Inc.
#
+# Copyright (C) 2009 Intel Corporation
+# April 2009 - Changes for MD support for isw format
+#
# This copyrighted material is made available to anyone wishing to use,
# modify, copy, or redistribute it subject to the terms and conditions of
# the GNU General Public License v.2, or (at your option) any later
version.
@@ -308,6 +311,21 @@ def udev_device_is_dmraid(info):
return False
+def udev_device_is_mdraid(info):
+ from formats.mdraid import MDRaidMember
+ from flags import flags
+ if info.has_key("ID_FS_TYPE"):
+ if flags.cmdline.has_key("iswmd"):
+ log.debug("found MD cmdline parameter")
+ if info["ID_FS_TYPE"] == "isw_raid_member":
+ log.debug("use MD for isw")
+ return True
+ else: + if info["ID_FS_TYPE"] in MDRaidMember._udevTypes:
+ return True
+
+ return False
+
This still does not look right, this will cause partitions
which are part of an mdraid (normal mdraid use) to
be added to the tree as storage devices, instead of partitions
which is wrong, and we do not need this, we only need
to add fakeraid member disks to the tree as StorageDevice instead
of DiskDevice, and we alrady do that with the
udev_device_is_dmraid set. Please drop this function
and the special case calling it, it is not needed.
Also can you please next time attach patches instead of sending
them inline, your mail client is mangling them.
Regards,
Hans
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
