On Tue, Apr 07, 2009 at 07:47:54PM +0200, Joel Granados wrote:
> On Tue, Apr 07, 2009 at 10:12:14AM -0500, David Lehman wrote:
> > On Tue, 2009-04-07 at 16:58 +0200, Joel Granados Moreno wrote:
> > > ---
> > > storage/__init__.py | 6 ++++++
> > > storage/partitioning.py | 6 ++++++
> > > 2 files changed, 12 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/storage/__init__.py b/storage/__init__.py
> > > index 7a9f93b..527ef48 100644
> > > --- a/storage/__init__.py
> > > +++ b/storage/__init__.py
> > > @@ -163,6 +163,12 @@ def storageComplete(anaconda):
> > > custom_buttons=[_("Go _back"),
> > > _("_Write changes to disk")],
> > > default = 0)
> > > +
> > > + # Make sure that all is down, even the disks that we setup after popluate.
> > > + for disk in anaconda.id.storage.disks:
> > > + if hasattr(disk, "teardown"):
> > > + disk.teardown()
> > > +
> > > if rc == 0:
> > > return DISPATCH_BACK
> > >
> > > diff --git a/storage/partitioning.py b/storage/partitioning.py
> > > index 5068450..e480842 100644
> > > --- a/storage/partitioning.py
> > > +++ b/storage/partitioning.py
> > > @@ -539,6 +539,12 @@ def doPartitioning(storage, exclusiveDisks=None):
> > > """
> > > anaconda = storage.anaconda
> > > disks = storage.disks
> > > +
> > > + # Activate them before we choose the exclusive ones only.
> > > + for disk in disks:
> > > + if hasattr(disk, "setup"):
> > > + disk.setup()
> > > +
> >
> > Why not wait and only set up the disks we are going to use?
> >
Any more issues besides this? I tested this extensively. I'm sure it
will work witht he exclusive disks as well.
> thats what exclusiveDisk is. Was not sure about it. Yep, sure, I can
> move it a couple of lines down.
>
> > > if exclusiveDisks:
> > > disks = [d for d in disks if d.name in exclusiveDisks]
> > >
> >
> > _______________________________________________
> > Anaconda-devel-list mailing list
> > Anaconda-devel-list@xxxxxxxxxx
> > https://www.redhat.com/mailman/listinfo/anaconda-devel-list
>
> --
> Joel Andres Granados
> Brno, Czech Republic, Red Hat.
>
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list
--
Joel Andres Granados
Brno, Czech Republic, Red Hat.
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
