On Mon, Apr 06, 2009 at 11:09:00AM -0500, David Lehman wrote: > On Mon, 2009-04-06 at 11:28 +0200, Joel Granados Moreno wrote: > > Hello list > > > > Arrived today to a bug with the dmraid custom partitioning caused when > > creating the extended partition. For some reason that step expects the > > node to be there. > > After speaking with hansg it might be better to just provide the dmraid > > nodes and not setup or tear them down. This will give the device a > > permanent presence throughout the install. > > To me this is the wrong approach. The right fix would be to find out > where we should be calling the devices' setup method and do so instead > of special-casing things like this. > > Dave I tried the approach where we call the setup for the disks before the partitioning and we tear them down afterward. It worked quite well, besides the increase in time needed to setup and teardown (but this is solvable if we put the teardown somewhere that its called at the end of partitioning instead of every iteration). I still think that the way to go is to not have the functions because having them and going through a setup-teardown cycle will bring us closer to what we had before where we activated the raids, did something and then deactivated them again. IMO, thats just something else to think about while you are doing stuff and, in the future, we will be expecting the dmraid array to be active after partitioning (for whatever reason) and will have to do another setup-teardown cycle (not good IMO). Having this in mind I give my +1 to not having the functions. Regards > > > > > Comments greatly appreciated. > > > > Joel Andres Granados > > Brno, Czech Republic, Red Hat. > > > > _______________________________________________ > > Anaconda-devel-list mailing list > > Anaconda-devel-list@xxxxxxxxxx > > https://www.redhat.com/mailman/listinfo/anaconda-devel-list > > _______________________________________________ > Anaconda-devel-list mailing list > Anaconda-devel-list@xxxxxxxxxx > https://www.redhat.com/mailman/listinfo/anaconda-devel-list -- Joel Andres Granados Brno, Czech Republic, Red Hat. _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
