Re: [PATCH] Create a min_max constraint to avoid alignments issues.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 06, 2009 at 02:26:59PM -0500, David Lehman wrote:
> On Mon, 2009-04-06 at 21:20 +0200, Joel Granados Moreno wrote:
> > ---
> >  storage/partitioning.py |   15 ++++++++++++---
> >  1 files changed, 12 insertions(+), 3 deletions(-)
> > 
> > diff --git a/storage/partitioning.py b/storage/partitioning.py
> > index eba0cb7..9e332ec 100644
> > --- a/storage/partitioning.py
> > +++ b/storage/partitioning.py
> > @@ -755,17 +755,26 @@ def allocatePartitions(disks, partitions):
> >  
> >          # create minimum geometry for this request
> >          # req_size is in MB
> > -        sectors_per_track = disk.device.biosGeometry[2]
> >          length = (_part.req_size * (1024 * 1024)) / sectorSize
> >          new_geom = parted.Geometry(device=disk.device,
> > -                                   start=max(sectors_per_track, free.start),
> > +                                   start=free.start,
> >                                     length=length)
> 
> I think you will have problems trying to create a partition with a start
> sector of less than 63. That's what the sectors_per_track variable was
> for.
I answered this in the previous thread :).  In anycase to be 100% sure,
will perform tests tmrrow.

> 
> >  
> > +        # create maximum and minimum geometries for constraint
> > +        start = max(0 , free.start - 1),
> > +        max_geom = parted.Geometry(device=disk.device,
> > +                                   start=start,
> > +                                   length=min(length + 1, disk.device.length - start))
> > +        min_geom = parted.Geometry(device=disk.device,
> > +                                   start=free.start + 1,
> > +                                   length=length-1)
> > +
> > +
> >          # create the partition and add it to the disk
> >          partition = parted.Partition(disk=disk,
> >                                       type=part_type,
> >                                       geometry=new_geom)
> > -        constraint = parted.Constraint(exactGeom=new_geom)
> > +        constraint = parted.Constraint(maxGeom=max_geom, minGeom=min_geom)
> >          disk.addPartition(partition=partition,
> >                            constraint=constraint)
> >          log.debug("created partition %s of %dMB and added it to %s" %
> 
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list

-- 
Joel Andres Granados
Brno, Czech Republic, Red Hat.

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux