On Thu, 2009-04-02 at 16:59 -1000, David Cantrell wrote:
> Looks good, but I have to ask why it was there in the first place?
> parted has a special identifier for PREP partitions, but if it's
> pointless, maybe that could be removed as well.
I put it there when I was still thinking out how to handle PReP
partitions. I decided that PReP is more of a format than anything else
so it got implemented as a DeviceFormat. We still use the parted flag.
Dave
>
> On 04/02/2009 04:44 PM, David Lehman wrote:
> > ---
> > storage/devices.py | 37 -------------------------------------
> > 1 files changed, 0 insertions(+), 37 deletions(-)
> >
> > diff --git a/storage/devices.py b/storage/devices.py
> > index 32ee2c7..0aacdaa 100644
> > --- a/storage/devices.py
> > +++ b/storage/devices.py
> > @@ -2747,43 +2747,6 @@ class DASDDevice(DiskDevice):
> > raise NotImplementedError("probe method not defined for StorageDevice")
> >
> >
> > -class PRePBootDevice(PartitionDevice):
> > - """ A PPC PReP boot partition.
> > -
> > - XXX Would this be better represented by a DeviceFormat class?
> > - """
> > - _type = "PReP"
> > - #_partedFlags = parted.PARTITION_PREP
> > -
> > - def __init__(self, device,
> > - size=None, grow=False, maxsize=None,
> > - major=None, minor=None,
> > - sysfsPath='', parents=None,
> > - exists=None, primary=False):
> > - """ Create a PRePBootDevice instance.
> > -
> > - Arguments:
> > -
> > - device -- the device name (generally a device node's basename)
> > -
> > - Keyword Arguments:
> > -
> > - grow -- whether or not to grow the partition (boolean )
> > - maxsize -- max size for growable partitions (units TBD)
> > - size -- the device's size (units/format TBD)
> > - major -- the device major
> > - minor -- the device minor
> > - sysfsPath -- sysfs device path
> > - parents -- a list of required Device instances
> > - exists -- indicates whether this is an existing device
> > - """
> > - PartitionDevice.__init__(self, device, partType=self._partType,
> > - size=size, grow=grow, maxsize=maxsize,
> > - major=major, minor=minor,
> > - sysfsPath=sysfsPath, exists=exists,
> > - parents=parents, primary=primary)
> > -
> > -
> > class NFSDevice(StorageDevice, NetworkStorageDevice):
> > """ An NFS device """
> > _type = "nfs"
>
>
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
