Re: [PATCH 2/3] Fix format check box for pre-existing partitions (#491675)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Radek Vykydal wrote:
David Cantrell wrote:

When performing a custom partitioning layout, make the Format check mark
column work correctly depending on what you enter in the Edit Partition
dialog box.  Also register and cancel storage actions as necessary.

I think you are hitting what I was, which is that we don't have origfs accessible here in UI (it is stored only in format action), but it seems we might need it. You are carrying over exists, migrate, size, and device through edited formats, but for migrate, we need also original format type (example: have preexisting ext3, Edit: choose format to ext2, next Edit: offers migration to ext3 - see below (*). Another similar example I met is "Original filesystem" label in raid dialog.

As I wrote some days ago I tried to store the original format in device, or
in UI in dict keyed with device, but maybe there is better way, or even
storing some info about original format is enough.

Another thing - we probably need to cancel also resize and migrate actions
if unchecked in reedit (similarly as with format)?
Well, now I noticed this patch is for Format check mark, which definitely works
better with it, so the patch looks good to me. (step by step:)

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux