Re: [PATCH 3/3] Move %pre processing to much earlier in the install process.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> diff --git a/anaconda b/anaconda
> index f47f50a..e7fc97d 100755
> --- a/anaconda
> +++ b/anaconda
> @@ -692,9 +692,9 @@ if __name__ == "__main__":
>      # for a couple specific commands that'll be useful in setting up the
>      # interface.
>      if opts.ksfile:
> -        from kickstart import earlyProcessKickstartFile
>          anaconda.isKickstart = True
> -        earlyKS = earlyProcessKickstartFile(anaconda, opts.ksfile)
> +        kickstart.preScriptPass(anaconda, opts.ksfile)
> +        earlyKS = kickstart.earlyCommandPass(anaconda, opts.ksfile)
>      else:
>          earlyKS = None
>  

After thinking about this one part of the patch, I don't feel very good
about it.  Moving where the %pre scripts get executed to this high up in
anaconda is a good idea as far as I'm concerned, but could have big
impacts on existing kickstart installations.  For instance, %pre scripts
will be run before there's any interface set up and I suppose it's
possible people are displaying something from their scripts.  This
change would break that.

I'm going to keep the parts of this patch that renames everything, but
move the kickstart.preScriptPass() to run in the same place it used to,
then push these patches.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux