Re: [PATCH 5/6] Look for a PReP "partition" by examining the format, not the flags (#492426).

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > diff --git a/booty/ppc.py b/booty/ppc.py
> > index 706f198..e49a865 100644
> > --- a/booty/ppc.py
> > +++ b/booty/ppc.py
> > @@ -16,7 +16,7 @@ class ppcBootloaderInfo(bootloaderInfo):
> >  
> >          if machine == 'pSeries':
> >              for dev in self.storage.fsset.devices:
> > -                if dev.partedFlags[parted.PARTITION_PREP] and not dev.format.exists:
> > +                if dev.format.type == "prepboot" and not dev.format.exists:
> 
> I'm not sure this is enough. If this is after we create the filesystems
> and whatnot all of the device will have their "exists" attribute set to
> True. This makes identifying non-preexisting devices difficult.

This is after we create filesystems, since we are now looking for
devices of the proper type that can be booted from.  I'm not sure that
the dev.format.exists test even needs to be there.  I don't know what
it's supposed to be doing.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux