David Cantrell wrote:
If 'Shrink current system' fails, _scheduleLVs() is still called which will cause a traceback. These two calls should be inside the try block for doAutoPartition(). --- storage/partitioning.py | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-)
Looks good.
diff --git a/storage/partitioning.py b/storage/partitioning.py index a71ba91..8e8d080 100644 --- a/storage/partitioning.py +++ b/storage/partitioning.py @@ -187,6 +187,12 @@ def doAutoPartition(anaconda): try: doPartitioning(anaconda.id.storage, exclusiveDisks=anaconda.id.storage.clearPartDisks) + + if anaconda.id.storage.doAutoPart: + _scheduleLVs(anaconda, devs) + + # grow LVs + growLVM(anaconda.id.storage) except PartitioningWarning as msg: if not anaconda.isKickstart: anaconda.intf.messageWindow(_("Warnings During Automatic " @@ -211,12 +217,6 @@ def doAutoPartition(anaconda): if anaconda.isKickstart: sys.exit(0)- if anaconda.id.storage.doAutoPart:- _scheduleLVs(anaconda, devs) - - # grow LVs - growLVM(anaconda.id.storage) - # sanity check the collection of devices log.warning("not sanity checking storage config because I don't know how yet") # now do a full check of the requests
_______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
