Re: network step always skipped in kickstart.py

[Matt Rose <mrose@xxxxxxxxxx>]

looked into this a little bit more, and this change here was exactly what I was looking for.

commit     062a1e5ebbf6dab03524a125c1ce34d3cea43fcb at http://git.fedorahosted.org/git/anaconda.git?p=anaconda.git;a=commit;h=062a1e5ebbf6dab03524a125c1ce34d3cea43fcb

>From the commit log:
> Some environments may want the assumption that no network line means you get prompted for network configuration.

The problem is, is that this patch was pulled out shortly after, with no explanation.  From looking over the patch, It's actually exactly what I was eventually aiming for with the patch below.  Does anyone know why it was pulled?

Matt

Matt Rose wrote:

I've built a rudimentary patch that works around the problem for my purposes, see below, but while that works with expected behaviour (leave out the network line, it should ask you to configure a network interface) that seems a little hacky, as it breaks down as soon as you have more than one interface...

The anaconda docs on the fedora wiki say "--bootproto=query" is the way to get kickstart to pop up the network configuration dialog.  (this does not work)

anaconda.spec mentions --bootproto=ask in anaconda 11.4, but it was pulled out shortly after, and obviously doesn't work.

Is this design intent, or something over-looked, or...

Matt

diff --git a/kickstart.py b/kickstart.py
index 82ae00b..3772672 100644
--- a/kickstart.py
+++ b/kickstart.py
@@ -1216,7 +1216,8 @@ def setSteps(anaconda):
     dispatch.skipStep("betanag")
     dispatch.skipStep("regkey")
     dispatch.skipStep("installtype")
-    dispatch.skipStep("network")
+    if self.ksdata.network:
+       dispatch.skipStep("network")
 
     # Don't show confirmation screens on non-interactive installs.
     if not interactive:

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list