Re: [PATCH 6/6] Let mountFilesystems handling bind mounting /dev (#490772).

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2009-03-23 at 10:46 -0400, Chris Lumens wrote:
> ---
>  livecd.py     |    1 -
>  rescue.py     |    6 ------
>  upgrade.py    |    2 --
>  yuminstall.py |    8 --------
>  4 files changed, 0 insertions(+), 17 deletions(-)

Great to see all that code removed.

> 
> diff --git a/livecd.py b/livecd.py
> index c6ed037..ac00e29 100644
> --- a/livecd.py
> +++ b/livecd.py
> @@ -312,7 +312,6 @@ class LiveCDCopyBackend(backend.AnacondaBackend):
>                  isys.mount("/selinux", anaconda.rootPath + "/selinux", "selinuxfs")
>              except Exception, e:
>                  log.error("error mounting selinuxfs: %s" %(e,))
> -        isys.mount("/dev", "%s/dev" %(anaconda.rootPath,), bindMount = True)
>  
>          wait.pop()
>  
> diff --git a/rescue.py b/rescue.py
> index fdd7847..7d480e7 100644
> --- a/rescue.py
> +++ b/rescue.py
> @@ -331,12 +331,6 @@ def runRescue(anaconda, instClass):
>                      except:
>                          log.error("Error enabling swap")
>  
> -                # now that dev is udev, bind mount the installer dev there
> -                isys.mount("/dev", "%s/dev" %(anaconda.rootPath,), bindMount = True)
> -
> -                # and /dev/pts
> -                isys.mount("/dev/pts", "%s/dev/pts" %(anaconda.rootPath,), bindMount = True)
> -
>                  # and /selinux too
>                  if flags.selinux and os.path.isdir("%s/selinux" %(anaconda.rootPath,)):
>                      try:
> diff --git a/upgrade.py b/upgrade.py
> index 7cb2f5d..c080c86 100644
> --- a/upgrade.py
> +++ b/upgrade.py
> @@ -277,8 +277,6 @@ def upgradeMountFilesystems(anaconda):
>                  message = message + '\t' + n + '\n'
>  	    anaconda.intf.messageWindow(_("Invalid Directories"), message)
>  	    sys.exit(0)
> -           
> -        bindMountDevDirectory(anaconda.rootPath)
>      else:
>          if not os.access (anaconda.rootPath + "/etc/fstab", os.R_OK):
>              anaconda.intf.messageWindow(_("Warning"),
> diff --git a/yuminstall.py b/yuminstall.py
> index 89f3668..9633032 100644
> --- a/yuminstall.py
> +++ b/yuminstall.py
> @@ -1457,14 +1457,6 @@ reposdir=/etc/anaconda.repos.d,/tmp/updates/anaconda.repos.d,/tmp/product/anacon
>                  except Exception, e:
>                      log.error("error mounting selinuxfs: %s" %(e,))
>  
> -            # we need to have a /dev during install and now that udev is
> -            # handling /dev, it gets to be more fun.  so just bind mount the
> -            # installer /dev
> -            log.warning("no dev package, going to bind mount /dev")
> -            isys.mount("/dev", "%s/dev" %(anaconda.rootPath,), bindMount = True)
> -            if not upgrade:
> -                anaconda.id.storage.fsset.mkDevRoot(anaconda.rootPath)
> -
>          # write out the fstab
>          if not upgrade:
>              anaconda.id.storage.fsset.write(anaconda.rootPath)

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux