Re: [PATCH] Fix traceback in FSSet.crypttab. (#491160)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Looks fine, some comments below.

On 03/20/2009 05:53 PM, David Lehman wrote:
---
  storage/__init__.py |    3 ++-
  1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/storage/__init__.py b/storage/__init__.py
index fdb8c91..7040104 100644
--- a/storage/__init__.py
+++ b/storage/__init__.py
@@ -1591,7 +1591,8 @@ class FSSet(object):
          devices = self.mountpoints.values() + self.swapDevices

          # prune crypttab -- only mappings required by one or more entries
-        for name in self.cryptTab.mappings:
+        names = self.cryptTab.mappings.keys()
+        for name in names:

I don't really have a problem with this, but why not:

    for name in self.cryptTab.mappings.keys():

              keep = False
              mapInfo = self.cryptTab[name]
              cryptoDev = mapInfo['device']


--
David Cantrell <dcantrell@xxxxxxxxxx>
Red Hat / Honolulu, HI

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux