Re: [anaconda-storage-branch PATCH] Avoid SIGSEGV in doPwMount() when NULL is last parameter (#491192)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2009-03-19 at 18:17 -1000, David Cantrell wrote:
> If NULL is given as the last parameter to doPwMount(), do not try
> to dereference it.

Looks good.

> ---
>  isys/imount.c |    8 +++++---
>  1 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/isys/imount.c b/isys/imount.c
> index 614e67e..fd51fde 100644
> --- a/isys/imount.c
> +++ b/isys/imount.c
> @@ -146,9 +146,11 @@ int doPwMount(char *dev, char *where, char *fs, char *options, char **err) {
>  
>      close(pipefd[1]);
>  
> -    if (*err != NULL) {
> -        rc = readFD(pipefd[0], err);
> -        rc = write(programLogFD, *err, 4096);
> +    if (err != NULL) {
> +        if (*err != NULL) {
> +            rc = readFD(pipefd[0], err);
> +            rc = write(programLogFD, *err, 4096);
> +        }
>      }
>  
>      close(pipefd[0]);

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux