On Thu, 2009-03-19 at 14:07 -0400, Jeremy Katz wrote:
> ---
> storage/udev.py | 9 ++++++++-
> 1 files changed, 8 insertions(+), 1 deletions(-)
Looks okay to me. I'm not sure splitting the blacklisting into two
places (DeviceTree and udev.py) is the best thing for maintainability,
but it doesn't seem like a big deal either way.
>
> diff --git a/storage/udev.py b/storage/udev.py
> index a6d3190..e8e8246 100644
> --- a/storage/udev.py
> +++ b/storage/udev.py
> @@ -39,11 +39,18 @@ def udev_get_block_devices():
> entries.append(entry)
> return entries
>
> +def __is_blacklisted_blockdev(dev_name):
> + """Is this a blockdev we never want for an install?"""
> + if dev_name.startswith("loop") or dev_name.startswith("ram"):
> + return True
> +
> + return False
> +
> def enumerate_block_devices():
> top_dir = "/sys/class/block"
> devices = []
> for dev_name in os.listdir(top_dir):
> - if dev_name.startswith("loop") or dev_name.startswith("ram"):
> + if __is_blacklisted_blockdev(dev_name):
> continue
> full_path = os.path.join(top_dir, dev_name)
> link_ref = os.readlink(full_path)
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
