Re: [PATCH 4/4] Add a FIXME comment for setting uuid in VG / LV create

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



What can I say ;) Should be fixed and the patch is not changing any code.. OK
Martin

----- "Hans de Goede" <hdegoede@xxxxxxxxxx> wrote:

> Add a FIXME comment for setting uuid in VG / LV create,
> so that we do not forget this needs fixing somewhere in the future.
> ---
>  storage/devices.py |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/storage/devices.py b/storage/devices.py
> index 0922778..dbfc9fa 100644
> --- a/storage/devices.py
> +++ b/storage/devices.py
> @@ -1621,6 +1621,7 @@ class LVMVolumeGroupDevice(DMDevice):
>          self.createParents()
>          self.setupParents()
>          lvm.vgcreate(self.name, pv_list, self.peSize)
> +        # FIXME set / update self.uuid here
>          self.exists = True
>          self.setup()
>  
> @@ -1906,6 +1907,7 @@ class LVMLogicalVolumeDevice(DMDevice):
>  
>          # should we use --zero for safety's sake?
>          lvm.lvcreate(self.vg.name, self._name, self.size)
> +        # FIXME set / update self.uuid here
>          self.exists = True
>          self.setup()
>  
> -- 
> 1.6.1.3
> 
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux