Re: PATCH: Stop overriding __init__ in DMRaidPartitionDevice

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



looks ok.
On Wed, Mar 18, 2009 at 10:31:32AM +0100, Hans de Goede wrote:
> We were overriding __init__ in DMRaidPartitionDevice only to pass
> everything through to our supers __init__. Lately we've been doing a bad
> job at this as we forget to pass through grow and maxSize causing troubles.
>
> Since all we want to do is pass everything through just not overriding __init__
> to begin with is the by far the best fix.
> ---
>  storage/devices.py |   11 -----------
>  1 files changed, 0 insertions(+), 11 deletions(-)
>
> diff --git a/storage/devices.py b/storage/devices.py
> index 367e044..8aef711 100644
> --- a/storage/devices.py
> +++ b/storage/devices.py
> @@ -2423,17 +2423,6 @@ class DMRaidPartitionDevice(PartitionDevice):
>      _packages = ["dmraid"]
>      devDir = "/dev/mapper"
>
> -    def __init__(self, name, format=None,
> -                 size=None, grow=False, maxsize=None,
> -                 major=None, minor=None, bootable=None,
> -                 sysfsPath='', parents=None, exists=None,
> -                 partType=None, primary=False):
> -        PartitionDevice.__init__(self, name, format=format, size=size,
> -                                 major=major, minor=minor, bootable=bootable,
> -                                 sysfsPath=sysfsPath, parents=parents,
> -                                 exists=exists, partType=partType,
> -                                 primary=primary)
> -
>      # We are more like a partition then a dmdevice, but we are still a dmdevice
>      # so we need to "inherit" some functions from dmdevice
>      def updateSysfsPath(self):
> -- 
> 1.6.1.3
>
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list

-- 
Joel Andres Granados
Brno, Czech Republic, Red Hat.

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux