David Lehman wrote:
On Tue, 2009-03-17 at 15:59 +0100, Hans de Goede wrote:
This patch renames storage.NetworkDevice to storage.NetworkStorageDevice,
as NetworkDevice as classname also is used in network.py .
It also changes NetworkStorageDevice so that it does not inherit from Device,
as it is now intended for use in multiple inheritance together with
StorageDevice (or a derived class) as explained further in the comments
in the code.
My intention with NetworkDevice was for it to be a stripped-down class
to represent a network interface, maybe even contain as an attribute the
"real" network interface instance from network.py. Devices like iscsi
would have the NetworkDevice as one of their parents, so they would have
a way to up/down the interface as needed to set up the device. However,
if this works well then great.
Then this patch changes iScsiDiskDevice and NFSDevice to additional inherit
from NetworkStorageDevice (next to what they were already inheriting from.
Again, not what I had imagined, but I didn't dig down to actually
implementing any network storage devices so maybe my plan was
impractical. The important thing is that it works well and minimizes
unnecessary entanglements, which it seems to do.
Ok,
pushed (with some syntax fixes, testing is good). in the future we might have to
revisit this, but for now this works and is pretty clean IMHO.
Regards,
Hans
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
