Re: [PATCH 1/2] Get iscsi going with the new storage code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





David Lehman wrote:
On Tue, 2009-03-17 at 15:59 +0100, Hans de Goede wrote:
This patch gets iscsi going with the new storage code. There are still
a few hicups left (such as NetworkManager downing the interface our / is on),
but I'll address those in separate patches.

Looks good.

---
 backend.py            |    6 ++++--
 isys/isys.py          |    9 ---------
 storage/devices.py    |   33 ++++++++++++---------------------
 storage/devicetree.py |   15 ++++++++++++---
 storage/iscsi.py      |   40 ++++++++++++++--------------------------
 storage/udev.py       |   30 ++++++++++++++++++++++++++++++
 yuminstall.py         |    7 -------
 7 files changed, 72 insertions(+), 68 deletions(-)
...
+
+    def __init__(self, device, **kwargs):
+        self.iscsi_name    = kwargs["iscsi_name"]
+        self.iscsi_address = kwargs["iscsi_address"]
+        self.iscsi_port    = int(kwargs["iscsi_port"])
+        del kwargs["iscsi_name"]
+        del kwargs["iscsi_address"]
+        del kwargs["iscsi_port"]
+        DiskDevice.__init__(self, device, **kwargs)
+        log.debug("created new iscsi disk %s %s:%d" % (self.iscsi_name, self.iscsi_address, self.iscsi_port))

You could use dict.pop() to make this more concise, but it's not
critical by any means.


Ah thanks, I was already looking for something like that, but clearly I didn't look hard
enough :)

Regards,

Hans

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux