Re: [PATCH anaconda-storage] Fixed the fs.py.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This patch was already posted by rvykydal.  We chose to wait for
dcantrells feedback.  Though I have tested it and it seems to work, I
would rather dcantrell review it.
On Tue, Mar 17, 2009 at 06:27:14AM -0400, Martin Gracik wrote:
> Forget this, it is already fixed
> 
> --
> Martin Gracik
> 
> ----- Original Message -----
> From: "Martin Gracik" <mgracik@xxxxxxxxxx>
> To: anaconda-devel-list@xxxxxxxxxx
> Sent: Tuesday, March 17, 2009 11:13:04 AM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna
> Subject: [PATCH anaconda-storage] Fixed the fs.py.
> 
> self._mountpoint is used instead of self.mountpoint in FS class.
> Also it was set always to None after getting the value from kwargs.
> ---
>  storage/formats/fs.py |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/storage/formats/fs.py b/storage/formats/fs.py
> index fa93136..6347fbe 100644
> --- a/storage/formats/fs.py
> +++ b/storage/formats/fs.py
> @@ -149,13 +149,14 @@ class FS(DeviceFormat):
>  
>          DeviceFormat.__init__(self, *args, **kwargs)
>          # TODO: fsprofiles and other ways to add format args
> -        self.mountpoint = kwargs.get("mountpoint")
> +        self._mountpoint = kwargs.get("mountpoint")
>          self.mountopts = kwargs.get("mountopts")
>          self.label = kwargs.get("label")
>  
>          # filesystem size does not necessarily equal device size
>          self._size = kwargs.get("size")
> -        self._mountpoint = None     # the current mountpoint when mounted
> +        # XXX why?
> +        #self._mountpoint = None     # the current mountpoint when mounted
>          if self.exists:
>              self._size = self._getExistingSize()
>  
> -- 
> 1.6.0.6
> 
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list
> 
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list

-- 
Joel Andres Granados
Brno, Czech Republic, Red Hat.

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux