On Monday, March 16 2009, David Lehman said: > On Mon, 2009-03-16 at 19:35 +0100, Hans de Goede wrote: > > David Lehman wrote: > > > On Mon, 2009-03-16 at 16:22 +0100, Hans de Goede wrote: > > >> When tearing down devices in devicetree.populate() we may fail to teardown > > >> certain LV's because they can be mounted (in the livecd case). > > > > > > This one is okay, but maybe what we really want here is to catch > > > Exception. > > > > Yes and No, we still want to backtrace for example in case of a syntax error > > or typo. Also it is sort of good to know which teardowns are known to fail from > > time to time. For example the lvm teardown failing is really just the tip of > > the iceberg of problems caused by filesystems we probe being mounted in the > > livecd environment. > > Maybe we should make a storage.errors.StorageError and have all the > other exception classes in that file inherit from it, so we can do > try...except StorageError. That's exactly the reply I was going to write :-) Jeremy _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
