David Lehman wrote:
On Mon, 2009-03-16 at 16:22 +0100, Hans de Goede wrote:
When tearing down devices in devicetree.populate() we may fail to teardown
certain LV's because they can be mounted (in the livecd case).
This one is okay, but maybe what we really want here is to catch
Exception.
Yes and No, we still want to backtrace for example in case of a syntax error
or typo. Also it is sort of good to know which teardowns are known to fail from
time to time. For example the lvm teardown failing is really just the tip of
the iceberg of problems caused by filesystems we probe being mounted in the
livecd environment.
Regards,
Hans
Mostly we just want to get things torn down as far as
possible so what we want is to catch just about evrything.
Thoughts?
---
storage/devicetree.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/storage/devicetree.py b/storage/devicetree.py
index a2d0386..8ae91ee 100644
--- a/storage/devicetree.py
+++ b/storage/devicetree.py
@@ -1332,7 +1332,7 @@ class DeviceTree(object):
for device in self.leaves:
try:
device.teardown(recursive=True)
- except (DeviceError, DeviceFormatError) as e:
+ except (DeviceError, DeviceFormatError, LVMError) as e:
log.info("teardown of %s failed: %s" % (device.name, e))
def setupAll(self):
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
