Chris Lumens wrote:
Looks good, a bit tricky though.
Tricky is my way.
hehe
Wouldn't it be better to raise an
exception in most of the case where you currently simply return
(such as add / remove partition) ?
We can certainly do that. I guess it's a matter of what the callers
expect and how this code acts when being run on a real machine.
Ack, which is why I suggested certain methods should raise an exception.
For attribute getters returning None in this case seems fine, but more
"active" functions like adding / removing a partition really should
throw an exception in this case IMHO. Trying to add a partition to a disk
without media should never happen (as it is not part of storage.disks)
Regards,
Hans
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
