Re: [PATCH 11/13] Only append free space part if we have one.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/15/2009 08:17 AM, David Lehman wrote:
On Fri, 2009-03-13 at 18:09 -1000, David Cantrell wrote:
When building the list of free space partitions, only append to
the list if we were able to find a partition.

This should not be necessary. I fixed a bug in
devices.PartitionDeviceFactory on Friday that caused newPartition to
sometimes return None. There should be no possibility of getting None
when calling newPartition.

Holding off on this one then.


Dave

---
  storage/partitioning.py |    5 +++--
  1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/storage/partitioning.py b/storage/partitioning.py
index f4c40f2..47800da 100644
--- a/storage/partitioning.py
+++ b/storage/partitioning.py
@@ -69,8 +69,9 @@ def _createFreeSpacePartitions(anaconda):
                                                  size=1,
                                                  grow=True,
                                                  disks=[disk])
-        anaconda.id.storage.createDevice(part)
-        devs.append(part)
+        if part:
+            anaconda.id.storage.createDevice(part)
+            devs.append(part)

      return (disks, devs)


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


--
David Cantrell <dcantrell@xxxxxxxxxx>
Red Hat / Honolulu, HI

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux