On Fri, 2009-03-13 at 18:09 -1000, David Cantrell wrote: > For autopartition requests as well as free space regions, set > exists=False when calling newPartition(). I think this was an attempt to work around that bug in PartitionDeviceFactory that caused it to return None in some cases. If so, let's get rid of it now that the bug's fixed. The constructor defaults the argument to None, which should be sufficient in all cases. Dave > --- > storage/partitioning.py | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/storage/partitioning.py b/storage/partitioning.py > index 47800da..7e84489 100644 > --- a/storage/partitioning.py > +++ b/storage/partitioning.py > @@ -68,7 +68,8 @@ def _createFreeSpacePartitions(anaconda): > part = anaconda.id.storage.newPartition(fmt_type=fmt_type, > size=1, > grow=True, > - disks=[disk]) > + disks=[disk], > + exists=False) > if part: > anaconda.id.storage.createDevice(part) > devs.append(part) > @@ -95,7 +96,8 @@ def _schedulePartitions(anaconda, disks): > grow=grow, > maxsize=maxsize, > mountpoint=mountpoint, > - disks=disks) > + disks=disks, > + exists=False) > > # schedule the device for creation > anaconda.id.storage.createDevice(dev) _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list