Re: [PATCH] Honor kickstart's clearpart --initlabel option.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





Chris Lumens wrote:
I hate to play the true, not true / yes, no game. But this is not true, see
partedUtils.py line 1008, we do take drives= in to account when forcefully
replacing disklabels because of --initlabel.

I refer you to autopart.py:1155.


Ah yes, but that is where it decides wether or not to clear partitions, and there it
clears partitions if initall is set and the drive has protected partitions (because we
skip the creating a new label when a disk has protected partitions).

So this is for clearing (removing) partitions from an existing table, not for writing a
brand new empty table, which is what --initlabel normally does. That happens in
partedUtils.py:1008.

Also notice that even in the autopart.py:1155 you refer to -drives= is honored as a couple
of line before in the loop is written:

        if (cleardrives and len(cleardrives) > 0 and not drive in cleardrives)
           drive in diskset.skippedDisks:
            continue

Regards,

Hans

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux