Re: [PATCH] Honor kickstart's clearpart --initlabel option.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





Chris Lumens wrote:
 storage/devices.py    |   40 +++++++++++++++++++++++++++-------------
 storage/devicetree.py |   14 ++++++++------
 2 files changed, 35 insertions(+), 19 deletions(-)
This looks a lot more reasonable.

Ack,

Note though that this versions seems to init ALL disks not only given
those as argument(s) to the clearpart command. This definitively has to
be fixed nuking the wrong partition table will not be taken lightly by
users.

Check out the partitioning code on master, and the clearpart command in
pykickstart.  --initlabel means to clear the disk label on all disks,
not just the ones specified with --drives=.  This is probably wrong
behavior, but it's what we've done and what people have (hopefully) come
to expect.

I hate to play the true, not true / yes, no game. But this is not true, see
partedUtils.py line 1008, we do take drives= in to account when forcefully
replacing disklabels because of --initlabel.

The one exception to this rule is that we do not initialize the disk
label on a disk that has protected partitions.

Ack.

Regards,

Hans

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux