Re: [PATCH] Fix a few bugs in the lvm dialog. (#489022)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Looks fine except the last block, comment below.

On 03/11/2009 12:34 PM, David Lehman wrote:
---
  iw/lvm_dialog_gui.py |    8 +++++---
  1 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/iw/lvm_dialog_gui.py b/iw/lvm_dialog_gui.py
index b3e2101..8847da6 100644
--- a/iw/lvm_dialog_gui.py
+++ b/iw/lvm_dialog_gui.py
@@ -339,7 +339,7 @@ class VolumeGroupEditor:

              if include:
                  partlist.append_row((device.name, size_string), selected)
-                if selected:
+                if selected and device not in self.vg.pvs:
                      self.vg._addPV(device)

  	return (partlist, sw)
@@ -548,7 +548,7 @@ class VolumeGroupEditor:
  	    # yet if we have not hit 'OK' for the volume group creation
  	    if fmt_class().mountable and mountpoint:
  		used = 0
-		curmntpt = format.mountpoint
+		curmntpt = getattr(format, "mountpoint", None)
  		
  		for _lv in self.vg.lvs:
                      if _lv.format.type == "luks":
@@ -908,7 +908,9 @@ class VolumeGroupEditor:

          # pvs, pesize are taken care of in widget callbacks
          # (clickCB, peChangeCB)
-        self.vg.name = volname
+        if self.vg.name != volname:
+            self.vg.name = volname
+

Is this change necessary?  Seems like the removed line is sufficient.

          if self.isNew:
              self.actions.insert(0, ActionCreateDevice(self.vg))
  	return self.actions


--
David Cantrell <dcantrell@xxxxxxxxxx>
Red Hat / Honolulu, HI

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux