> > > + # Have we already created the DMRaidArrayDevice? > > > + rs = block.getRaidSetFromRelatedMem(uuid=uuid, name=name, > > > + major=major, minor=minor) > > > + if rs is None: > > > + # FIXME: Should handle not finding a dmriad dev better > > > + pass > > > > Shouldn't this be 'return'? > > This means that something very strange is going on. because we found a > dmraid device and we cannot find the dmraidArray that it relates to. > Just returning seems odd because the installation would continue without > any further action. Guess the best thing to do here is to ignore the > device and continue. Right. My only concern is that the next line makes a method call with rs.name (or similar) as an argument, which will obviously cause a failure if rs is None. I'd suggest to log it and then do whatever you want as long as it doesn't cause a traceback :-) Dave _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
