Re: [anaconda-storage-branch] Added crypto.py unittest; Updated devicelibs tests baseclass.py and lvm.py

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> baseclass.py needed some imports to work properly.
> Updated the test for getMaxLVSize() in lvm.py to not pass PE size as argument.
> ---
>  tests/storage/devicelibs/baseclass.py |    4 +
>  tests/storage/devicelibs/crypto.py    |  123 +++++++++++++++++++++++++++++++++
>  tests/storage/devicelibs/lvm.py       |    3 +-
>  3 files changed, 128 insertions(+), 2 deletions(-)
>  create mode 100644 tests/storage/devicelibs/crypto.py

I can't speak to the correctness of the tests themselves since I don't
know all about the encryption code.  However, this certainly is a
thorough set of test cases and I say go ahead and commit.  We can
revisit them later if we find problems.  I like that there's a number of
test cases that are expected to fail, too.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux