Re: [PATCH 2/8] Use the right attributes to build the bootloaderChoices dict.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





Chris Lumens wrote:
diff --git a/platform.py b/platform.py
index 4adc5d1..2c35a5c 100644
--- a/platform.py
+++ b/platform.py
@@ -83,11 +83,11 @@ class Platform(object):
         if not bootDev:
             return ret
- if bootDev.device.getName() == "RAIDDevice":
-            ret["boot"] = (bootDev.path, N_("RAID Device"))
+        if bootDev.type == "mdarray":
I think you should also check for "dm-raid array".  Not really familiar
with the booty code, but it seem reasonable.

Hm, can you even boot off DM RAID devices?


Yes you can, that is the purpose of having BIOS raid, you can even boot of fakeraid5
/ 10 / whatever exotic of which mdraid can not boot, with that said what I know of
the original code (I had to touch it to fix some obscore 4.8 bug), this special check
only was meant for mdraid and not for dmraid, so I do not agree with Joel's suggestion.

Regards,

Hans

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux