On Sun, 2009-03-01 at 20:32 -1000, David Cantrell wrote:
> We don't have this function anymore, but I don't know if we need
> to be calling anything else.
We might want to add something, I'm not sure to be honest. Mostly,
device settings are checked at set-time via properties. There are
probably a few things that are not controlled in this way that should
be.
We might want to at least leave the isMountPointInUse check in place.
> ---
> iw/lvm_dialog_gui.py | 11 -----------
> iw/partition_dialog_gui.py | 15 ---------------
> iw/raid_dialog_gui.py | 6 ------
> 3 files changed, 0 insertions(+), 32 deletions(-)
>
> diff --git a/iw/lvm_dialog_gui.py b/iw/lvm_dialog_gui.py
> index 6e093fe..3aebb20 100644
> --- a/iw/lvm_dialog_gui.py
> +++ b/iw/lvm_dialog_gui.py
> @@ -675,17 +675,6 @@ class VolumeGroupEditor:
> if luksdev:
> actions.append(ActionCreateDevice(luksdev))
>
> - err = self.storage.sanityCheckRequest(lv,
> - skipMntPtExistCheck=1,
> - pesize=pesize)
> - if not err:
> - err = self.storage.isMountPointInUse(lv)
> -
> - if err:
> - self.intf.messageWindow(_("Error With Request"),
> - "%s" % (err), custom_icon="error")
> - continue
> -
> if usedev.format.exists and format.mountable and \
> self.storage.formatByDefault(usedev) and \
> not queryNoFormatPreExisting(self.intf):
> diff --git a/iw/partition_dialog_gui.py b/iw/partition_dialog_gui.py
> index 2fdf856..b64d3bf 100644
> --- a/iw/partition_dialog_gui.py
> +++ b/iw/partition_dialog_gui.py
> @@ -175,15 +175,6 @@ class PartitionEditor:
> primary=primary,
> parents=disks)
>
> - err = storage.sanityCheckRequest(request)
> - if not err:
> - err = doUIRAIDLVMChecks(request, self.storage)
> -
> - if err:
> - self.intf.messageWindow(_("Error With Request"),
> - "%s" % (err), custom_icon="error")
> - continue
> -
> # we're all set, so create the actions
> if luksdev:
> actions.append(ActionCreateDevice(luksdev))
> @@ -221,12 +212,6 @@ class PartitionEditor:
> if request.format.type != "none":
> actions.append(ActionResizeFormat(request, size))
>
> - err = self.storage.sanityCheckRequest(request)
> - if err:
> - self.intf.messageWindow(_("Error With Request"),
> - "%s" % (err), custom_icon="error")
> - continue
> -
> if request.format.exists and \
> getattr(request, "mountpoint", None) and \
> self.storage.formatByDefault(request):
> diff --git a/iw/raid_dialog_gui.py b/iw/raid_dialog_gui.py
> index 8757bbc..900e450 100644
> --- a/iw/raid_dialog_gui.py
> +++ b/iw/raid_dialog_gui.py
> @@ -201,12 +201,6 @@ class RaidEditor:
> self.fsoptionsDict["migratecb"].get_active():
> fstype = self.fsoptionsDict["migfstypeCombo"].get_active_value()
>
> - err = self.storage.sanityCheckRequest(request)
> - if err:
> - self.intf.messageWindow(_("Error With Request"),
> - "%s" % (err), custom_icon="error")
> - continue
> -
> if request.format.exists and \
> self.storage.formatByDefault(request):
> if not queryNoFormatPreExisting(self.intf):
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
