Re: rhel5-branch [PATCH 1/2] Fix for traceback in Partitions.doMetaDeletes.addSnap() (#433824)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch looks ok.

Just out of curiousity:  I'm wondering why the trace back says line 1372 and
the patch is on line 1599.  Do you have the bug number?

Regards

On Fri, Feb 20, 2009 at 05:00:23PM -1000, David Cantrell wrote:
> Traceback (most recent call first):
>   File "/usr/lib/anaconda/partitions.py", line 1372, in addSnap
>     snaps = snapshots[name]
>   File "/usr/lib/anaconda/partitions.py", line 1383, in doMetaDeletes
>     addSnap(delete.name, delete.vg)
>   File "/usr/lib/anaconda/packages.py", line 144, in turnOnFilesystems
>     anaconda.id.partitions.doMetaDeletes(anaconda.id.diskset)
>   File "/usr/lib/anaconda/dispatch.py", line 201, in moveStep
>     rc = stepFunc(self.anaconda)
>   File "/usr/lib/anaconda/dispatch.py", line 124, in gotoNext
>     self.moveStep()
>   File "/usr/lib/anaconda/gui.py", line 1018, in nextClicked
>     self.anaconda.dispatch.gotoNext()
>   File "/usr/lib/anaconda/iw/progress_gui.py", line 243, in renderCallback
>     self.intf.icw.nextClicked()
>   File "/usr/lib/anaconda/gui.py", line 1045, in handleRenderCallback
>     self.currentWindow.renderCallback()
> KeyError: 'data'
> ---
>  partitions.py |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/partitions.py b/partitions.py
> index 47ae4df..f2292dc 100644
> --- a/partitions.py
> +++ b/partitions.py
> @@ -1599,6 +1599,8 @@ class Partitions:
>          lvm_parent_deletes = []
>          tmp = {}
>          def addSnap(name, vg):
> +            if not snapshots.has_key(name):
> +                return
>              snaps = snapshots[name]
>              for snap, snapvg in snaps:
>                  addSnap(snap, snapvg)
> -- 
> 1.6.1.3
> 
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list

-- 
Joel Andres Granados
Brno, Czech Republic, Red Hat.

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux