Re: [PATCH 2/4] Use direct reference instead of setattr().

Hans de Goede <hdegoede@xxxxxxxxxx> · Sat, 21 Feb 2009 09:50:26 +0100

David Cantrell wrote:
pychecker fix.
---
 anaconda_log.py |    2 +-
 iw/task_gui.py  |    6 ++----
 2 files changed, 3 insertions(+), 5 deletions(-)


Looks good,

Regards,

Hans

diff --git a/anaconda_log.py b/anaconda_log.py
index 99ae58e..7ed5d45 100644
--- a/anaconda_log.py
+++ b/anaconda_log.py
@@ -46,7 +46,7 @@ class LoggerClass(logging.Logger):
 
     # Specialized addHandler that also adds the autoSetLevel attribute.
     def addHandler(self, hdlr, autoSetLevel=True):
-        setattr(hdlr, "autoSetLevel", autoSetLevel)
+        hdlr.autoSetLevel = autoSetLevel
         logging.Logger.addHandler(self, hdlr)
 
 class AnacondaLog:
diff --git a/iw/task_gui.py b/iw/task_gui.py
index 04032d3..9851469 100644
--- a/iw/task_gui.py
+++ b/iw/task_gui.py
@@ -467,11 +467,9 @@ class TaskWindow(InstallWindow):
             # we just set things as default or not; group selection
             # happens after this screen.
             if cb:
-                map(lambda g: setattr(self.backend.ayum.comps.return_group(g),
-                                      "default", True), grps)
+                map(lambda g: self.backend.ayum.comps.return_group(g).default = True, grps)
             else:
-                map(lambda g: setattr(self.backend.ayum.comps.return_group(g),
-                                      "default", False), grps)
+                map(lambda g: self.backend.ayum.comps.return_group(g).default = False, grps)
 
     def _editRepo(self, *args):
         repo = None

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list




