Re: [PATCH] Don't check for a swapfs on things that aren't partitions (#485977).

[David Cantrell <dcantrell@xxxxxxxxxx>]

Chris Lumens wrote:
> ---
>  partIntfHelpers.py |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/partIntfHelpers.py b/partIntfHelpers.py
> index 0c6541c..13c8722 100644
> --- a/partIntfHelpers.py
> +++ b/partIntfHelpers.py
> @@ -402,7 +402,7 @@ def checkForSwapNoMatch(anaconda):
>      diskset = anaconda.id.diskset
>  
>      for request in anaconda.id.partitions.requests:
> -        if not request.dev or not request.fstype:
> +        if not hasattr(request, "drive") or not request.fstype:
>              continue
>  
>          for drive in request.drive:

I think this is ok for our current storage code.  We also use 
isinstance() throughout anyway.  While it's not pretty, it is in line 
with our current code and I think it's acceptable.

--
David Cantrell <dcantrell@xxxxxxxxxx>
Red Hat / Honolulu, HI

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list