Re: PATCH: pyparted: Do not keep a borrowed refence without INCREF-ing it

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> In _ped_Disk_init we store a borrowed reference in self->dev (through
> PyArg_ParseTuple()). We INCREF this on success at the end. But we keep it
> without INCREF-ing it in an error path. This path clears the borrowed reference
> in the error path. This fixes various cases of python crashing when having
> an invalid partition table.

Seems likely that we're doing this same thing in several other places,
too.  Did you go looking for those, or is that something I need to do?
Other than that, looks fine.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux