Re: [PATCH] Added support for mdadm raid10 installs (#467996)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday, February 18 2009, Martin Gracik said:

> there's no liveinst.sh in my rhel5-branch (at least I can't find it, maybe I'm doing something wrong?), so that's why I didn't change it.

Aha!  Mentioning the branch in these cases is really useful.  There's
nothing[1] really to tip the hat in that direction in the patch
 
> About the raid list, I looked at how it's done in fedora branch, and took the logic from there.
> I can change it back to the "old logic", just adding the RAID10 into the tupple. It should work...

Aha, I see why the logic changed -- otherwise, RAID10 was matching for
RAID1.  But spelunking through commit logs (and then the referenced bug)
was necessary.

Hence why it's useful to have a good commit message for logic changes
like this one rather than having them in the middle of a "support a new
raid type" commit  

Jeremy

[1] Well, I guess I could have looked at the tree-ish identifiers.  But
that's more time than it's usually worth

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux